Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return '0' if cell is '0', empty otherwise #19

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

steppicrew
Copy link

Distinguish between empty cells and cells containing '0'

@jholster
Copy link

Is the library anymore maintained? The first pull request for this bug was sent more than a year ago ("Fix when row[key] == 0"). Neither that or this pull request has been merged.

@steppicrew
Copy link
Author

steppicrew commented Nov 11, 2016

I think you're right: it seems not to be maintained anymore.
But the patched module works for us so we thought we'd add a pull request. Afterwards we realized that there already was one addressing the same problem, but I think our is slightly better so we let you chose which to merge... ;-)

@jholster
Copy link

@steppicrew I forked your fork, made minor modifications so that it installs with yarn, and published it as xlsx-writestream2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants