Include Boost as CMake subproject #6510

Pansysk75 · 2024-06-17T18:58:43Z

Draft PR for properly fetching and installing boost as a CMake subproject.
Still needs fixes, but I paused working on it since we need boostorg/cmake#65 to move forward with this approach.

Can also move to using find_package Config mode, since Module mode (using Find<PackageName>.cmake) is being deprecated for Boost.

codacy-production · 2024-06-17T22:36:36Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.42%	✅ ∅

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`f4ff6e8`)	232431	198777	85.52%
Head commit (`a4ad166`)	190890 (-41541)	162445 (-36332)	85.10% (-0.42%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#6510)	0	0	∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

StellarBot · 2024-09-11T20:47:22Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	--	--	--

Info

Property	Before	After
HPX Datetime	2024-03-18T14:00:30+00:00	2024-09-11T20:38:57+00:00
HPX Commit	`d27ac2e`	`7dc3dee`
Datetime	2024-03-18T09:18:04.949759-05:00	2024-09-11T15:44:44.707287-05:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Clustername	rostam	rostam

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	--

Info

Property	Before	After
HPX Datetime	2024-03-18T14:00:30+00:00	2024-09-11T20:38:57+00:00
HPX Commit	`d27ac2e`	`7dc3dee`
Datetime	2024-03-18T09:19:53.062988-05:00	2024-09-11T15:46:35.458781-05:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Clustername	rostam	rostam

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	--	--	--
Stream Benchmark - Scale	--	--	---
Stream Benchmark - Triad	--	--	--
Stream Benchmark - Copy	--	--	--

Info

Property	Before	After
HPX Datetime	2024-03-18T14:00:30+00:00	2024-09-11T20:38:57+00:00
HPX Commit	`d27ac2e`	`7dc3dee`
Datetime	2024-03-18T09:20:13.002391-05:00	2024-09-11T15:46:53.043751-05:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Clustername	rostam	rostam

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

StellarBot · 2024-09-11T23:50:17Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	--	--	--

Info

Property	Before	After
HPX Commit	`d27ac2e`	`a13a00d`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-09-11T23:02:42+00:00
Envfile
Clustername	rostam	rostam
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Datetime	2024-03-18T09:18:04.949759-05:00	2024-09-11T18:47:49.715016-05:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	--

Info

Property	Before	After
HPX Commit	`d27ac2e`	`a13a00d`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-09-11T23:02:42+00:00
Envfile
Clustername	rostam	rostam
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Datetime	2024-03-18T09:19:53.062988-05:00	2024-09-11T18:49:40.919742-05:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	--	--	--
Stream Benchmark - Scale	--	--	---
Stream Benchmark - Triad	--	--	--
Stream Benchmark - Copy	--	--	--

Info

Property	Before	After
HPX Commit	`d27ac2e`	`a13a00d`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-09-11T23:02:42+00:00
Envfile
Clustername	rostam	rostam
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Datetime	2024-03-18T09:20:13.002391-05:00	2024-09-11T18:49:58.643620-05:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

Pansysk75 · 2024-09-25T14:54:24Z

@srinivasyadav18 This now works, I just have to make some fixes to the CI environments before merging

StellarBot · 2024-10-08T14:48:42Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	--	--	--

Info

Property	Before	After
HPX Commit	`d27ac2e`	`b53ef80`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-10-02T14:46:20+00:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Datetime	2024-03-18T09:18:04.949759-05:00	2024-10-08T09:45:40.304270-05:00
Clustername	rostam	rostam
Envfile

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	--

Info

Property	Before	After
HPX Commit	`d27ac2e`	`b53ef80`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-10-02T14:46:20+00:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Datetime	2024-03-18T09:19:53.062988-05:00	2024-10-08T09:47:30.867770-05:00
Clustername	rostam	rostam
Envfile

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	--	--	--
Stream Benchmark - Scale	--	--	---
Stream Benchmark - Triad	--	--	--
Stream Benchmark - Copy	--	-	--

Info

Property	Before	After
HPX Commit	`d27ac2e`	`b53ef80`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-10-02T14:46:20+00:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Datetime	2024-03-18T09:20:13.002391-05:00	2024-10-08T09:47:51.334507-05:00
Clustername	rostam	rostam
Envfile

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

StellarBot · 2024-11-04T18:17:26Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	--	--	--

Info

Property	Before	After
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-04T16:25:55+00:00
HPX Commit	`d27ac2e`	`cad8155`
Datetime	2024-03-18T09:18:04.949759-05:00	2024-11-04T12:14:31.519906-06:00
Envfile
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Clustername	rostam	rostam
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	--

Info

Property	Before	After
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-04T16:25:55+00:00
HPX Commit	`d27ac2e`	`cad8155`
Datetime	2024-03-18T09:19:53.062988-05:00	2024-11-04T12:16:22.435694-06:00
Envfile
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Clustername	rostam	rostam
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	--	--	--
Stream Benchmark - Scale	--	--	---
Stream Benchmark - Triad	--	--	--
Stream Benchmark - Copy	--	--	--

Info

Property	Before	After
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-04T16:25:55+00:00
HPX Commit	`d27ac2e`	`cad8155`
Datetime	2024-03-18T09:20:13.002391-05:00	2024-11-04T12:16:41.231817-06:00
Envfile
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Clustername	rostam	rostam
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

codacy-production · 2024-11-04T20:00:35Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.46%	✅ ∅

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`342d373`)	234436	200546	85.54%
Head commit (`04789f4`)	193829 (-40607)	164927 (-35619)	85.09% (-0.46%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#6510)	0	0	∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

…ility

StellarBot · 2024-11-06T15:48:24Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	--	--	--

Info

Property	Before	After
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-06T15:35:57+00:00
HPX Commit	`d27ac2e`	`a4f0a99`
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Clustername	rostam	rostam
Datetime	2024-03-18T09:18:04.949759-05:00	2024-11-06T09:45:16.128200-06:00
Envfile

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	--

Info

Property	Before	After
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-06T15:35:57+00:00
HPX Commit	`d27ac2e`	`a4f0a99`
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Clustername	rostam	rostam
Datetime	2024-03-18T09:19:53.062988-05:00	2024-11-06T09:47:05.928436-06:00
Envfile

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	--	--	--
Stream Benchmark - Scale	--	--	---
Stream Benchmark - Triad	--	--	--
Stream Benchmark - Copy	--	--	---

Info

Property	Before	After
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-06T15:35:57+00:00
HPX Commit	`d27ac2e`	`a4f0a99`
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Clustername	rostam	rostam
Datetime	2024-03-18T09:20:13.002391-05:00	2024-11-06T09:47:26.397781-06:00
Envfile

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

Pansysk75 added category: CMake type: enhancement type: compatibility issue labels Jun 17, 2024

Pansysk75 force-pushed the fetch-boost-add-subdirectory branch 2 times, most recently from 34d3833 to f86b00c Compare September 11, 2024 20:38

Pansysk75 force-pushed the fetch-boost-add-subdirectory branch from f86b00c to 2208267 Compare September 11, 2024 22:04

hkaiser mentioned this pull request Sep 12, 2024

Add HPX to Godbolt Compiler Explorer #6541

Open

Pansysk75 mentioned this pull request Nov 2, 2024

Fix HPX_WITH_FETCH_BOOST #6511

Closed

2 tasks

Pansysk75 force-pushed the fetch-boost-add-subdirectory branch from 9d5f9b0 to cad8155 Compare November 4, 2024 16:26

Pansysk75 added 5 commits November 6, 2024 09:34

Fetch Boost as a CMake subproject

4e3b511

Use find_package to locate HPX-installed Boost

ff09dc5

Fix conflict with pkgconfig generation

12cf5c1

Add ENV{BOOST_ROOT} hint to CMake find_package for backwards compatib…

dd828c6

…ility

Update vcpkg packages on windows CI

04789f4

Pansysk75 force-pushed the fetch-boost-add-subdirectory branch from cad8155 to 04789f4 Compare November 6, 2024 15:35

Include Boost as CMake subproject #6510

Are you sure you want to change the base?

Include Boost as CMake subproject #6510

Conversation

Pansysk75 commented Jun 17, 2024 • edited Loading

codacy-production bot commented Jun 17, 2024 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

StellarBot commented Sep 11, 2024

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

StellarBot commented Sep 11, 2024

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

Pansysk75 commented Sep 25, 2024

StellarBot commented Oct 8, 2024

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

StellarBot commented Nov 4, 2024

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

codacy-production bot commented Nov 4, 2024 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

StellarBot commented Nov 6, 2024

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

Pansysk75 commented Jun 17, 2024 •

edited

Loading

codacy-production bot commented Jun 17, 2024 •

edited

Loading

codacy-production bot commented Nov 4, 2024 •

edited

Loading