Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable resolving hostnames if TCP is disabled #6389

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Disable resolving hostnames if TCP is disabled #6389

merged 2 commits into from
Nov 22, 2023

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Nov 14, 2023

Fixes #6388

@JiakunYan would you be able to check whether this resolves the issue you reported?

Copy link

codacy-production bot commented Nov 14, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% 36.36%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (31a8a03) 189436 161286 85.14%
Head commit (b9ba56a) 189031 (-405) 160926 (-360) 85.13% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6389) 22 8 36.36%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@JiakunYan
Copy link
Contributor

Is it possible to also disable these (

hpx_host = mapnames.map(hpx_host, hpx_port);
and
agas_host = mapnames.map(agas_host, agas_port);
)? The map function will also call resolve_hostname.

@hkaiser
Copy link
Member Author

hkaiser commented Nov 19, 2023

Is it possible to also disable these (

hpx_host = mapnames.map(hpx_host, hpx_port);

and

agas_host = mapnames.map(agas_host, agas_port);

)? The map function will also call resolve_hostname.

Done. Thanks!

@JiakunYan
Copy link
Contributor

Should work now! I only tested it on 2 nodes. I need to let the Expanse support team test the program on 128 nodes to see whether it really fixes things or not, but I think we can merge it now.

@hkaiser hkaiser force-pushed the fixing_6388 branch 2 times, most recently from 98f02d4 to 6afeffc Compare November 19, 2023 12:59
@hkaiser hkaiser merged commit 5ffdfbe into master Nov 22, 2023
47 of 52 checks passed
@hkaiser hkaiser deleted the fixing_6388 branch November 22, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HPX error: "Host not found" when running on Expanse with 128 nodes
2 participants