Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(doxy): don't extract private members #6022

Merged

Conversation

bhumitattarde
Copy link
Contributor

No description provided.

hkaiser
hkaiser previously approved these changes Sep 30, 2022
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser
Copy link
Member

hkaiser commented Sep 30, 2022

bors merge

@bors
Copy link

bors bot commented Sep 30, 2022

Merge conflict.

@hkaiser
Copy link
Member

hkaiser commented Sep 30, 2022

@bhumitattarde could you please rebase onto master to resolve the conflict?

@bhumitattarde
Copy link
Contributor Author

@hkaiser check now?

@bhumitattarde bhumitattarde requested review from hkaiser and removed request for msimberg, biddisco and aurianer October 6, 2022 06:41
@hkaiser
Copy link
Member

hkaiser commented Oct 6, 2022

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser
Copy link
Member

hkaiser commented Oct 6, 2022

bors merge

bors bot pushed a commit that referenced this pull request Oct 6, 2022
6022: build(doxy): don't extract private members r=hkaiser a=bhumitattarde



Co-authored-by: Bhumit Attarde <[email protected]>
@bors
Copy link

bors bot commented Oct 6, 2022

Timed out.

@hkaiser hkaiser merged commit b6c3e1b into STEllAR-GROUP:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants