Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty 'exec_policy::nested' class #643

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Conversation

SSoelvsten
Copy link
Owner

This class is essentially dead code...

@SSoelvsten SSoelvsten added the ✨ code quality Uncle Bob would be proud label Mar 15, 2024
@SSoelvsten SSoelvsten self-assigned this Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.315%. Comparing base (615f1e4) to head (aeae577).

❗ Current head aeae577 differs from pull request most recent head fc84ee6. Consider uploading reports for the commit fc84ee6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #643   +/-   ##
=========================================
  Coverage   97.315%   97.315%           
=========================================
  Files           90        90           
  Lines         6480      6480           
=========================================
  Hits          6306      6306           
  Misses         174       174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 15, 2024

🟡 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'origin/exec_policy/remove-nested' is a change in performance of -0.03% (stdev: 1.15%).

... origin/main origin/exec_policy/remove-nested
Mean 24318.33 24325.33
Standard Deviation 174.86 279.46

Number of samples: 3

Copy link

github-actions bot commented Mar 15, 2024

🟢 Regression Test (12-Queens)

'origin/exec_policy/remove-nested' is a change in performance of 0.09% (stdev: 0.59%).

... origin/main origin/exec_policy/remove-nested
Mean 11511.50 11500.75
Standard Deviation 41.38 67.56

Number of samples: 4

Copy link

github-actions bot commented Mar 15, 2024

🟡 Regression Test (Picotrav 'adder')

'origin/exec_policy/remove-nested' is a change in performance of -3.60% (stdev: 8.95%).

... origin/main origin/exec_policy/remove-nested
Mean 9160.70 9490.20
Standard Deviation 113.47 849.49

Number of samples: 10

Copy link

github-actions bot commented Mar 15, 2024

🟢 Regression Test (Picotrav 'mem_ctrl')

'origin/exec_policy/remove-nested' is a change in performance of 0.23% (stdev: 0.23%).

... origin/main origin/exec_policy/remove-nested
Mean 113163.67 112898.67
Standard Deviation 259.21 247.52

Number of samples: 3

Copy link

github-actions bot commented Mar 15, 2024

🟡 Regression Test (14-Queens)

'origin/exec_policy/remove-nested' is a change in performance of -0.31% (stdev: 0.37%).

... origin/main origin/exec_policy/remove-nested
Mean 266171.33 267001.67
Standard Deviation 935.52 993.36

Number of samples: 3

Copy link

github-actions bot commented Mar 15, 2024

🟡 Regression Test (QBF 'connect4/4x4_9_connect3_bwnib')

'origin/exec_policy/remove-nested' is a change in performance of -1.32% (stdev: 1.72%).

... origin/main origin/exec_policy/remove-nested
Mean 1158.50 1173.75
Standard Deviation 9.54 20.17

Number of samples: 4

Copy link

github-actions bot commented Mar 15, 2024

🟡 Regression Test (Picotrav 'arbiter')

'origin/exec_policy/remove-nested' is a change in performance of -0.07% (stdev: 0.39%).

... origin/main origin/exec_policy/remove-nested
Mean 62945.67 62990.00
Standard Deviation 245.61 189.60

Number of samples: 3

Copy link

🟡 Regression Test (QBF 'domineering/5x5_13_bwnib')

'origin/exec_policy/remove-nested' is a change in performance of -0.19% (stdev: 0.88%).

... origin/main origin/exec_policy/remove-nested
Mean 22700.33 22744.00
Standard Deviation 120.23 199.67

Number of samples: 3

Copy link

🔴 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')

'origin/exec_policy/remove-nested' is a change in performance of -1.55% (stdev: 1.49%).

... origin/main origin/exec_policy/remove-nested
Mean 4174.75 4239.25
Standard Deviation 35.13 63.23

Number of samples: 4

Copy link

🟢 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'origin/exec_policy/remove-nested' is a change in performance of 0.38% (stdev: 1.17%).

... origin/main origin/exec_policy/remove-nested
Mean 11382.25 11338.50
Standard Deviation 132.71 111.46

Number of samples: 4

@SSoelvsten SSoelvsten merged commit 6cc054c into main Mar 15, 2024
49 of 56 checks passed
@SSoelvsten SSoelvsten deleted the exec_policy/remove-nested branch March 15, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ code quality Uncle Bob would be proud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant