Redo reference counting #98
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the API easier to use, and means there are less safety requirements that we have to document.
Also clean up other comments
See f52bc56, but that change made it very easy to create unbounded references, or create two aliasing mutable references.
The lifetime of the parameter is the lifetime of references in the pool. This allows us to bound lifetimes on autoreleased objects, thereby making them safe to return.
This was referenced Jun 3, 2021
|
Like you mention in your comment here: #95 (comment) I'd like to build this out-of-crate for now. objc-id was my attempt, and I'm not that happy with it. Perhaps you can build this in another crate first and prove it there? |
|
Can you elaborate on what you were unhappy with in |
This was referenced Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My WIP on #95.
Adds
Retained, a smart pointer version ofStrongPtr, but with more guarantees. Notably, this has anDeref<Target = T>implementation, which makes it more ergonomic and safer to use.Also adds
Owned, the mutable version ofRetainedwith aDerefMut<Target = T>implementation.I'm thinking about removing
StrongPtrcompletely in favour of this (since it's behaviour can be achieved withRetained<Object>), but please voice your opinion on this, and how we should handle backwards compatibility.