Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do a new release. #66

Closed
jrmuizel opened this issue Jun 28, 2018 · 3 comments
Closed

Do a new release. #66

jrmuizel opened this issue Jun 28, 2018 · 3 comments

Comments

@jrmuizel
Copy link
Contributor

It would be nice to have a new release with selector caching.
@kvark
Copy link

kvark commented Jun 28, 2018

As for us, using a cargo override (at the portability's root toml) works fine during development. I'd love to see #65 resolved in an eventually published version.

@SSheldon
Copy link
Owner

SSheldon commented Jul 7, 2018

I was going to publish a while ago but hit something that needed a bit more thought. The objc crate doesn't specify a minimum required version of rust, but it works pretty far back (maybe all the way to 1.0). When testing the new version I realized it stopped working on at least 1.14 because of:

  • omitting the field name when initializing Sel, which requires rust 1.17
  • using AtomicPtr::new in a constant, which requires rust 1.24

I don't know if anyone is still using objc on rust pre-1.24 and objc doesn't have any official policy about this, but... I'm a little uncomfortable bumping the minimum version up so far in a patch version.

I might look into how to make this change backwards compatible before publishing.

SSheldon added a commit that referenced this issue Jul 7, 2018
@SSheldon
Preserve backwards compatibility for old rust versions
df36b02 
As mentioned in #66, the new release will just be a patch release. To
be on the safe side, we can preserve backwards compatibility by working
around the following two incompatibilities:

* omitting the field name when initializing `Sel`, which requires rust 1.17
* using `AtomicPtr::new` in a constant, which requires rust 1.24
@SSheldon
Copy link
Owner

SSheldon commented Jul 7, 2018

Version 0.2.3 is published!

@SSheldon SSheldon closed this as completed Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kvark @jrmuizel @SSheldon