Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS ◾ Improved rule on "test please" readability #9804

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Conversation

tiagov8
Copy link
Member

@tiagov8 tiagov8 commented Jan 27, 2025

cc @adamcogan @Levijj22

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Checking test please rule since I was looking for UI testing

  1. What was changed?

Added headings and improved overall semantics

@tiagov8 tiagov8 changed the title Improved "test please" readability Improved rule on "test please" readability Jan 27, 2025
@tiagov8 tiagov8 enabled auto-merge (squash) January 27, 2025 20:29
@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Jan 27, 2025
Copy link
Contributor

github-actions bot commented Jan 27, 2025

PR Metrics

Thanks for keeping your pull request small.

Lines
Product Code -
Test Code 17
Subtotal 17
Ignored Code -
Total 17

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Improved rule on "test please" readability XS ◾ Improved rule on "test please" readability Jan 27, 2025
Copy link
Contributor

Hi @tiagov8,

Rule: ../../rules/conduct-a-test-please/rule.md

Issues Detected:

  • must have required property 'seoDescription'

Please fix the Frontmatter in your Markdown files.

Copy link
Contributor

Hi @tiagov8,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/conduct-a-test-please/rule.md Line 70: column count Rule MD056

Please review and update your Markdown files accordingly.

@github-actions github-actions bot added Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐥 - Adolescent About 8 hours old labels Jan 28, 2025
Copy link
Contributor

Hi @tiagov8,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/conduct-a-test-please/rule.md Line 71: column count Rule MD056

Please review and update your Markdown files accordingly.

@tiagov8 tiagov8 requested review from adamcogan and uly1 January 28, 2025 10:53
@github-actions github-actions bot added Age: 🐓 - Old About 32 hours old and removed Age: 🐤 - Mature About 16 hours old labels Jan 28, 2025
@tiagov8 tiagov8 merged commit 1d12189 into main Jan 28, 2025
4 of 5 checks passed
@tiagov8 tiagov8 deleted the tiagov8-patch-24 branch January 28, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🐓 - Old About 32 hours old
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants