Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipa: Set proper SDAP_KRB5_REALM for subdomain options #7854

Closed
wants to merge 1 commit into from
Closed

ipa: Set proper SDAP_KRB5_REALM for subdomain options #7854

wants to merge 1 commit into from
+1 −5

Conversation

justin-stephenson
Copy link
Contributor

Creating this as draft so I can test this does not break IPA IPA trust

@thalman thalman mentioned this pull request Feb 27, 2025
Open
@justin-stephenson justin-stephenson marked this pull request as ready for review February 28, 2025 19:14
@justin-stephenson
Copy link
Contributor Author

justin-stephenson commented Feb 28, 2025 •
edited
Loading

This is ready for review, CI failures are unrelated.

thalman
thalman approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@thalman thalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@alexey-tikhonov
Copy link
Member

@justin-stephenson, is this needed in sssd-2-9?

@justin-stephenson
Copy link
Contributor Author

@justin-stephenson, is this needed in sssd-2-9?

Yes, thanks for the reminder. I added the label

@andreboscatto andreboscatto requested a review from sumit-bose March 4, 2025 13:45
@alexey-tikhonov
Copy link
Member

@sumit-bose, could you please take a look?

@justin-stephenson justin-stephenson force-pushed the ipa_subdom_sdap_opts_fix branch from 5911c1d to a452194 Compare March 20, 2025 12:59
@justin-stephenson justin-stephenson force-pushed the ipa_subdom_sdap_opts_fix branch from a452194 to 9834d45 Compare March 20, 2025 13:40
sumit-bose
sumit-bose approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@sumit-bose sumit-bose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

thank you for the update, ACK.

bye,
Sumit

@alexey-tikhonov
Copy link
Member

@thalman, would you like to take a look at the latest version?

@alexey-tikhonov alexey-tikhonov requested a review from thalman March 21, 2025 09:17
thalman
thalman approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@thalman thalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK for new version, thanks

@alexey-tikhonov alexey-tikhonov added coverity Trigger a coverity scan Ready to push Ready to push labels Mar 21, 2025
@alexey-tikhonov
Copy link
Member

Pushed PR: #7854

  • master
    • a7b3255 - ipa: Set proper domain basedn for subdomain options
  • sssd-2-9
    • 3bc17c6 - ipa: Set proper domain basedn for subdomain options

@alexey-tikhonov alexey-tikhonov removed the Ready to push Ready to push label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thalman thalman thalman approved these changes

@sumit-bose sumit-bose sumit-bose approved these changes

Assignees

@thalman thalman

@sumit-bose sumit-bose

Labels
branch: sssd-2-9 coverity Trigger a coverity scan Pushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justin-stephenson @alexey-tikhonov @thalman @sumit-bose