Skip to content

Conversation

@jorgemarpa
Copy link
Contributor

This PR updates the FFI loading methods to be more memory efficient plus other minor changes.

Changes:

  • loading FFIs using fitsio and reading only the asked data
  • loading FFIs will attempt to preserve cadence quality. Useful when working with TESS FFIs.
  • ffi.load_from_file() and tpf.from_TPFS() both accept the keyword sources for custom user input.
  • ffi.flux_2d is a property useful for plotting functions
  • saturated and bright pixels are masked into machine.source_mask and machine.uncontaminated_pixel_mask
  • updated keyword arguments:
    • dist_lim --> sparse_dist_lim as machine attribute so it can be modified depending on instrument pixel scale (e.g. TESS)
    • time_corrector was deprecated and Perturbation handles this
    • machine.sources_flux_column to designate globally which column from the source catalog will be used as flux estimate. This update is necessary for TESS which uses the R band instead of G.
  • Gaia query now also saves RP and BP flux columns
  • plot_shape_model() has flexible radii and color mapping stretch from flux percentiles. This is useful for other instruments (TESS)

Copy link
Contributor Author

@jorgemarpa jorgemarpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to run demo notebooks to check consistent results

Copy link
Contributor Author

@jorgemarpa jorgemarpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor Author

@jorgemarpa jorgemarpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake8 passing

Copy link
Contributor Author

@jorgemarpa jorgemarpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake8 passing

@jorgemarpa jorgemarpa merged commit 0697eb4 into SSDataLab:master Jun 9, 2023
@jorgemarpa jorgemarpa deleted the tess-ffi branch June 14, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant