-
Notifications
You must be signed in to change notification settings - Fork 5
Efficient FFI loading #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jorgemarpa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to run demo notebooks to check consistent results
jorgemarpa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
jorgemarpa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flake8 passing
jorgemarpa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flake8 passing
This PR updates the FFI loading methods to be more memory efficient plus other minor changes.
Changes:
fitsioand reading only the asked dataffi.load_from_file()andtpf.from_TPFS()both accept the keywordsourcesfor custom user input.ffi.flux_2dis a property useful for plotting functionsmachine.source_maskandmachine.uncontaminated_pixel_maskdist_lim-->sparse_dist_limasmachineattribute so it can be modified depending on instrument pixel scale (e.g. TESS)time_correctorwas deprecated andPerturbationhandles thismachine.sources_flux_columnto designate globally which column from thesourcecatalog will be used as flux estimate. This update is necessary for TESS which uses the R band instead of G.plot_shape_model()has flexible radii and color mapping stretch from flux percentiles. This is useful for other instruments (TESS)