docs(kanban): fix stale skipped_nonspawnable docstring event reference (HEL-3114 follow-up)

[SSC-ENG]

Summary

Follow-up to PR #6 (HEL-3114) TRC review low-severity finding (GO verdict, comment #6 (comment)).

DispatchResult.skipped_nonspawnable's docstring in hermes_cli/kanban_db.py still referenced the removed dispatch_nonspawnable_assignee event. Since PR #6 removed the superseded record_nonspawnable helper, that event kind is no longer emitted anywhere; the durable signal is the pre_dispatch_validation_failed event (error_code=missing_assignee_profile) emitted via reject_pre_dispatch. This PR corrects the docstring to name the actual event kind.

Linear

HEL-3114 (adjacent follow-up; TRC finding from the HEL-3114 review)

Changes

• hermes_cli/kanban_db.py: docstring-only correction on DispatchResult.skipped_nonspawnable (+4/-2 lines, no behavior change).

Test evidence

• Docstring/comment-only change; python3 -c "import ast; ast.parse(...)" syntax check passes.
• Grep confirms dispatch_nonspawnable_assignee no longer appears anywhere in the tree, and pre_dispatch_validation_failed is the emitted event kind (kanban_db.py:8419 via reject_pre_dispatch).

Deployment impact / rollback

None — documentation-only. Rollback: revert the single commit.

[SSC-ENG]

TRC Technical Review — VERDICT: GO / APPROVE

PR: SSC-ENG/hermes-agent #11 — docs(kanban): fix stale skipped_nonspawnable docstring event reference (HEL-3114 follow-up)
Exact head reviewed: de47d0f8a4d0c2e717e10f6f5c29f94b706c5f36 (verified live, no drift from the review request)
Base: main — mergeStateStatus CLEAN, MERGEABLE
Kanban: t_f628a10d (review of cole-espinoza's t_2e3aed49, RRA lane t_516a58b5)

Entry gate

• Commit on properly named branch fix/hel-3114-stale-nonspawnable-docstring — PASS
• Branch pushed, PR head OID equals reviewed SHA — PASS
• PR body links HEL-3114 with summary, test evidence, deployment impact, rollback — PASS
• CI exists and is green at the exact head — PASS

Findings (all verified against the tree at de47d0f, fresh shallow fetch)

1. Scope is exactly as declared. gh pr diff 11 shows a single hunk in hermes_cli/kanban_db.py: the DispatchResult.skipped_nonspawnable docstring (+4/−2), documentation-only. No behavior change.
2. Docstring now matches the real emitted event. reject_pre_dispatch (kanban_db.py:8378) emits pre_dispatch_validation_failed via _append_event (:8421), and both nonspawnable-assignee skip paths (:8583, ~:8736) call it with PreDispatchFailure(code="missing_assignee_profile") immediately after appending to result.skipped_nonspawnable. The corrected docstring names exactly that: pre_dispatch_validation_failed (error_code=missing_assignee_profile, via reject_pre_dispatch). Accurate.
3. Stale event kind fully gone. Tree-wide grep at de47d0f: dispatch_nonspawnable_assignee — zero occurrences in *.py / *.md. This closes my low-severity finding from the PR fix(kanban): preserve legacy dispatch compatibility #6 (HEL-3114) GO review (pull/6#issuecomment-5128976162).
4. Syntax proof: ast.parse(hermes_cli/kanban_db.py) passes at the exact head.

Exact-head CI (run 30535374635 @ de47d0f)

gh pr checks 11 + statusCheckRollup verified against headRefOid de47d0f8…: "All required checks pass" — SUCCESS. All 8 Python test slices, e2e, Desktop E2E (Playwright), ruff enforcement + ruff/ty diff, Windows footguns, uv.lock check, OSV/supply-chain scans, attribution, common-ancestor: SUCCESS. Skipped jobs (JS/TS, Docker build/publish, Docs Site, package-lock diff, Lint Docker scripts, PyPI upper bounds, save-durations, Review label gate) are path-filter skips — correct for a Python-docstring-only diff.

Disposition

GO. No findings at any severity. Structurally present and behaviorally proven for the reviewable claim (docstring correctness is proven by code inspection at the exact head; no runtime behavior is asserted or changed). Merge lane may proceed: hand to cole-espinoza (t_2e3aed49) / RRA (rhea-ramos) per standing merge-lane ownership. Head drift after de47d0f invalidates this verdict.

---

— Tessa Cole · credentials: eng-technical-review (TRC) · agent: tessa-cole

🪙 Token usage (from Hermes state.db — real per-session data)

session	model	in	out	reasoning	est cost
20260730_040633_27716c	anthropic/claude-fable-5	114,588	3,804	0	$1.4512 (est)
TOTAL	—	114,588	3,804		$1.4512

profile: tessa-cole · cost estimated unless marked (act). Recorded per the tokens-to-value deliverable.

CPTC actual: compare these real tokens with the predicted Complexity Points on the technical-scope sub-issue.