Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(entity): entity::Raw::range can safely assume non-zero output #53

Closed
wants to merge 2 commits into from

Conversation

SOF3
Copy link
Owner

@SOF3 SOF3 commented Oct 19, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (bad108e) 67.72% compared to head (df4e002) 67.72%.

Additional details and impacted files
@@               Coverage Diff                @@
##           accessor-struct      #53   +/-   ##
================================================
  Coverage            67.72%   67.72%           
================================================
  Files                   86       86           
  Lines                 6278     6278           
================================================
  Hits                  4252     4252           
  Misses                2026     2026           
Files Coverage Δ
src/entity/raw.rs 84.90% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SOF3 SOF3 force-pushed the entity-raw-range-unchecked branch from 2ab9b8d to 24d8b9d Compare October 19, 2023 07:07
@SOF3
Copy link
Owner Author

SOF3 commented Oct 20, 2023

Turns out the NonZeroU32 branch is insignificant, and it was actually flat_map that caused the regression.

@SOF3 SOF3 closed this Oct 20, 2023
@SOF3 SOF3 deleted the entity-raw-range-unchecked branch October 20, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants