Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate yield $generator #118

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Deprecate yield $generator #118

merged 1 commit into from
Jun 10, 2022

Conversation

SOF3
Copy link
Owner

@SOF3 SOF3 commented Mar 20, 2022

Prefer yield from $generator instead.

@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #118 (ebf50ae) into master (2d9be5c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head ebf50ae differs from pull request most recent head 5b53c55. Consider uploading reports for the commit 5b53c55 to get more accurate results

@@            Coverage Diff            @@
##             master     #118   +/-   ##
=========================================
  Coverage     99.41%   99.42%           
- Complexity      126      127    +1     
=========================================
  Files            10       10           
  Lines           342      345    +3     
=========================================
+ Hits            340      343    +3     
  Misses            2        2           
Impacted Files Coverage Δ
await-generator/src/SOFe/AwaitGenerator/Await.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d9be5c...5b53c55. Read the comment docs.

@SOF3
Copy link
Owner Author

SOF3 commented Mar 20, 2022

re coverage: not gonna cover the deprecation check, because it uses a static property. This is something we cannot unit test anyway.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is no good enough in pocketmine mp serfver it say this not helpful message to server owner and confuse they

tell plugin coder to put this funciton in onLoad() onEnable() so disable this not helpful message pls

@SOF3 SOF3 force-pushed the deprecate-direct-yields branch from 0bdac4d to ebf50ae Compare June 10, 2022 05:45
Prefer `yield from $generator` instead.
@SOF3 SOF3 force-pushed the deprecate-direct-yields branch from ebf50ae to 5b53c55 Compare June 10, 2022 16:57
@SOF3 SOF3 enabled auto-merge (squash) June 10, 2022 16:57
@SOF3 SOF3 merged commit 91f6e29 into master Jun 10, 2022
@ghost
Copy link

ghost commented Jun 10, 2022

:DDDDd

@SOF3 SOF3 deleted the deprecate-direct-yields branch June 12, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant