Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trio: small fixes #88

Merged
merged 4 commits into from
Dec 20, 2022
Merged

trio: small fixes #88

merged 4 commits into from
Dec 20, 2022

Conversation

linuxmaniac
Copy link
Contributor

with this changes I only get

================================================================================================================================ short test summary info ================================================================================================================================
FAILED tests/test_stack.py::test_async_run - AttributeError: 'Scenario' object has no attribute 'finalize'
====================================================================================================================== 1 failed, 58 passed, 32 warnings in 37.56s =======================================================================================================================
ERROR: InvocationError for command /home/vseva/data/projects/pysipp/.tox/py39/bin/pytest tests/ (exited with code 1)
________________________________________________________________________________________________________________________________________ summary ________________________________________________________________________________________________________________________________________
ERROR:   py39: commands failed

@linuxmaniac linuxmaniac mentioned this pull request Dec 19, 2022
Open
4 tasks
@linuxmaniac
Copy link
Contributor Author

@goodboy apart of the problem of black formatting, the only issue is calling Scenario.finalize() at tests/test_stack.py::test_async_run

goodboy
goodboy approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@goodboy goodboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lit! yeah let's get this in and we'll work through the last test on #87

@goodboy goodboy merged commit 6f524e4 into SIPp:trio_subprocs Dec 20, 2022
@linuxmaniac linuxmaniac deleted the vseva/trio branch December 20, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodboy goodboy goodboy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linuxmaniac @goodboy