-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logdir is not respected in Scenario.defaults #20
Labels
Comments
Closed
goodboy
pushed a commit
that referenced
this issue
Jul 28, 2016
These changes are hand picked from PR #17. For #20 this fixes the bug where underlying `Agents` do not have their `logdir` attribute set properly when passed to `pysipp.scenario`. Also included is support for more command line flags including: -oocsf, -users, -deadcall_wait and -trace_error_codes. Closes #18
goodboy
added a commit
that referenced
this issue
Jul 5, 2019
The `defaults` kwarg to `pysipp.agent.Scenario` isn't used so just drop it and instead comb through provided `kwargs` and pop out values passed by the user into `pysipp.agent.Scenario.defaults` making these the "new" defaults applied to agents. Also, rename the default settings dicts more explicitly. Resolves #20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thanks to @fchareyron for finding this in #19.
It seems we never respect the
logdir
arg passed intopysipp.walk()
orpysipp.scenario()
such that it's never set inpysipp.Scenario.defaults
. It is however overridden in the underlying agents (by original design) but this is arguably not clear to the user.In other words:
@fchareyron's change to
pysipp/__init__.py:96
:does resolve this at the
Agent
level forpysipp.scenario
as per:but
logdir
should really be assigned inScenario.defaults
as well.We need a test and fix for this.
The text was updated successfully, but these errors were encountered: