Toggle for skipping dependency if it cannot be parsed #224
Conversation
Skipping toggle for unparseable dependencies when running 'ci-cd update-deps'.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
==========================================
+ Coverage 80.85% 81.11% +0.25%
==========================================
Files 12 12
Lines 888 900 +12
==========================================
+ Hits 718 730 +12
Misses 170 170 ☔ View full report in Codecov by Sentry. |
| "package naming is allowed by user. Note, the requirements could " | ||
| f"not be parsed: {exc}" | ||
| ) | ||
| LOGGER.info(msg) |
There was a problem hiding this comment.
I'm not sure if I like the fact that both LOGGER and print are being used to pass messages to the user
There was a problem hiding this comment.
The logs are for the developers, not users. The context for this function is that it is run through the command line. So I use print-statements to communicate with the user (in the respective streams (stdout or stderr) depending on the message "level".
So again, the logs are used for debugging and testing, while print statements are used to communicate with the user.
This is a broad-fix for #208.
A new input is created for the CI - Check pyproject.toml dependencies callable workflow:
skip_unnormalized_python_package_names. A boolean to toggle "whether to skip dependencies with unnormalized Python package names. Normalization is outlined here: https://packaging.python.org/en/latest/specifications/name-normalization. Default isfalse."To implement this functionality a new flag is created for
ci-cd update-deps:--skip-unnormalized-python-package-names.Additionally, the argument tables for the pre-commit hooks have been updated slightly, replacing the type
booleanwithflagand switching the columnsTypeandDefaultdue to a different sense of importance.