Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang format rule: Indent preprocessor directives #1702

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Clang format rule: Indent preprocessor directives #1702

merged 2 commits into from
Nov 1, 2024

Conversation

heinezen
Copy link
Member

Aligns the clang formatting rules for preprocesser directives with what we already use in the files.

@heinezen heinezen added lang: c++ Done in C++ code code quality Does not alter behavior, but beauty of our code labels Oct 31, 2024
@heinezen heinezen mentioned this pull request Oct 31, 2024
Merged
TheJJ
TheJJ approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@TheJJ TheJJ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the macros in util/macro look slightly worse - the rest is good!

@TheJJ TheJJ merged commit 31f74ee into SFTtech:master Nov 1, 2024
13 checks passed
@heinezen heinezen deleted the fx/clang_format_ppindent branch November 25, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJJ TheJJ TheJJ approved these changes

Assignees
No one assigned
Labels
code quality Does not alter behavior, but beauty of our code lang: c++ Done in C++ code
Projects
openage code quality
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heinezen @TheJJ