Fix order of processing input contexts #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heinezen
added
improvement
heinezen
force-pushed
the
fix/input-contexts-order
branch
2 times, most recently
from
7cfa962 to
b6d3741
Compare
heinezen
added
the
kevin-rebuild-pl0x
SFTbot
removed
the
kevin-rebuild-pl0x
heinezen
force-pushed
the
fix/input-contexts-order
branch
from
b6d3741 to
ecb41d2
Compare
TheJJ
reviewed
Apr 22, 2024
heinezen
force-pushed
the
fix/input-contexts-order
branch
2 times, most recently
from
33201fd to
02de382
Compare
heinezen
force-pushed
the
fix/input-contexts-order
branch
from
02de382 to
51c8c4f
Compare
TheJJ
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the order in which input contexts are searched. The intended order was LIFO (like a stack) but the implemented order was FIFO (like a list).
This was a nice opportunity to useDisregard that because clang is too old :(std::views::reversefrom therangeslibrary in C++20 :DI also added a separate callback list for mouse move actions to the window because mixing them with mouse button actions can be annoying during debugging. This lead me to discover an error in the input demo where some keybindings were not properly assigned which is now also fixed.