Coordinate types pretty print #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heinezen
added
improvement
TheJJ
previously approved these changes
Apr 18, 2024
heinezen
force-pushed
the
feature/pretty_print_coord
branch
from
7f3d4d8 to
3b13d76
Compare
|
@TheJJ Wouldn't this require switching away from the decorator method? I would like to keep that for now, since it makes adding new printers pretty easy. |
heinezen
force-pushed
the
feature/pretty_print_coord
branch
from
3b13d76 to
d46f0d4
Compare
heinezen
force-pushed
the
feature/pretty_print_coord
branch
from
d46f0d4 to
b92138d
Compare
|
the decorator can be imported like any regular function, no? |
|
@TheJJ Yes, but to use the decorator, the module with the classes would have to be imported too. And somehow, gdb doesn't seem to like that. At least I get errors when I try that for the .gdbinit file but gdb doesn't print the exact issue. I'm not sure how to solve this yet, so having the printers all in one file is the best solution right now. |
TheJJ
previously approved these changes
Apr 20, 2024
|
@TheJJ Done :) |
heinezen
force-pushed
the
feature/pretty_print_coord
branch
from
625dab4 to
0aa78a0
Compare
TheJJ
previously approved these changes
Apr 20, 2024
heinezen
added
the
kevin-rebuild-pl0x
SFTbot
removed
the
kevin-rebuild-pl0x
heinezen
force-pushed
the
feature/pretty_print_coord
branch
from
0aa78a0 to
d79640e
Compare
heinezen
added
the
kevin-rebuild-pl0x
SFTbot
removed
the
kevin-rebuild-pl0x
|
Now it should be good to merge, finally |
TheJJ
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1633
This just flattens the parent hierarchy to make the parent invisible and directly show the coordinate values.