Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added flake #1631

Merged
merged 2 commits into from
Mar 31, 2024
Merged

feat: added flake #1631

merged 2 commits into from
Mar 31, 2024

Conversation

akiross
Copy link
Contributor

@akiross akiross commented Mar 29, 2024

Hello,
as discussed on matrix few days ago, I'm proposing this PR to add support for nix.

While possibly not idiomatic, this works and adds also support for nyan.

@heinezen
Copy link
Member

heinezen commented Mar 30, 2024

Hey thanks a lot,

I just have one small suggestion: Could you add the nix build to our build instructions list? That would make the fact that nix is available as an option more obvious. Also, could you link some info on how to maintain these files inside the docs because I assume it's written down somewhere but we don't know nix well enough to know where to look :D

@akiross
Copy link
Contributor Author

akiross commented Mar 31, 2024

Sure I can! I will add a bunch of comments inside the nix files to aid maintaining them.

Oh, just for info: this was tested on Linux (amd64 NixOS) only, I am not sure other platforms (e.g. OSX) are working, since I cannot test them at the moment.

@akiross
Copy link
Contributor Author

akiross commented Mar 31, 2024

I added some build and dev instructions specific for nix. I updated building.md to do what "seems intuitive" (list nix among the dependency section), but it's not just that: this solution is a complete build specification, so it would require a different section in that file altogether. But for the people looking for nix, the current doc might be fine.

I also fixed a couple of things related to the code itself and added comments to the main files (flake.nix and openage.nix).

@heinezen
Copy link
Member

Thanks a lot! This will make it much easier to update and check out.

@heinezen heinezen merged commit 666844d into SFTtech:master Mar 31, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants