Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta test that subtracts points #209

Closed
martinmladenov opened this issue Jun 11, 2023 · 4 comments
Closed

Meta test that subtracts points #209

martinmladenov opened this issue Jun 11, 2023 · 4 comments
Assignees
@FrancescoHamar @puctom
Labels
enhancement New feature or request Low priority

Comments

@martinmladenov
Copy link
Collaborator

Sometimes we want a meta test that doesn't give points if the student got it right, but subtracts points from the students that got it wrong.

This is similar to code checks that subtract points in #168
@martinmladenov martinmladenov added enhancement New feature or request Low priority labels Jun 11, 2023
@martinmladenov martinmladenov mentioned this issue Jun 11, 2023
Closed
@puctom
Copy link
Contributor

puctom commented Jul 5, 2023

I want to work on this one

@mauricioaniche
Copy link
Contributor

Great, @puctom. Please drop a message in our internal channel, so we know who you are :)

@martinmladenov any extra tips to @puctom on this one? You implemented something similar to code checks, maybe you have some nice lessons learned?

@martinmladenov
Copy link
Collaborator Author

I'd advise you to look into PR #210 since it does something very similar. I think the easiest way to implement this would be to make a separate step which runs those meta tests (while of course being careful not to introduce duplicated code).

@FrancescoHamar
Copy link
Contributor

Hello! Could I also be assigned to this one as we would work together on it?

This was referenced Sep 1, 2023
Closed
Merged
martinmladenov added a commit that referenced this issue May 1, 2024
@FrancescoHamar @puctom @martinmladenov
Added Meta test that subtracts points #209 (#266)
fec659f 
* remove upstream

* introducing penalty metachecks

* Added penalty meta test exectution step

* added penalty meta tests to final output writer

* added logging for penalty metatest

* fixed equals in exec step

* suitable Result constructor in testutils

* Penalty MetaTests integration Tests _1

* Update README with penalty meta tests description

* More tests on PenaltyMetaTests

* Increase consistency in writing the result

* improve conditions about displaying metatests and codechecks results

* Standard result writer tests

* penalty meta tests in Weblab result writer

* Remove unnecessary import

* Fix logic bug

* Revert "Increase consistency in writing the result"

This reverts commit bc24b9c.

* Revert output format changes

---------

Co-authored-by: puctom <[email protected]>
Co-authored-by: Martin Mladenov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrancescoHamar FrancescoHamar

@puctom puctom

Labels
enhancement New feature or request Low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mauricioaniche @martinmladenov @FrancescoHamar @puctom