-
Notifications
You must be signed in to change notification settings - Fork 65
Coarsen and Snapping #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Coarsen and Snapping #514
Conversation
@bobpaw Feel free to take a look at the code now |
@bobpaw are you still reviewing? |
Yes, sorry. I have a few more longer files to look at. I had also submitted a patch to Angel via email which adjusts his isCapstone function slightly. I'll finish up the review today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for lots of comments. After this PR is merged I will be working on adding Doxygen documentation for new and improved features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Might be worth configuring with VALGRIND=valgrind
and running ctests (probably excluding the long capstone tests -E '^capVol.*'
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I agree with @bobpaw about running valgrind/address sanitizer on the tests. A few small comments are below.
@Angelyr The changes look good. Thank you. Once we have checked with valgrind/asan I think this will be ready to merge. |
Changes to coarsen
Changes to snapping
More testing
Most of the these changes to snapping and coarsen came from Li's thesis with some minor exceptions: