Skip to content

Conversation

@Sichao25
Copy link
Collaborator

@Sichao25 Sichao25 commented May 1, 2025

Solved the warning related to #480 . std::iterator is set to be deprecated in C++17. We are expected to define the types exposed by our iterators.

@cwsmith
Copy link
Contributor

cwsmith commented May 1, 2025

/runtests

@github-actions
Copy link

github-actions bot commented May 1, 2025

Build Log
Simmetrix Test Result: success
Simmetrix + CGNS Test Result: failure

@cwsmith
Copy link
Contributor

cwsmith commented May 2, 2025

/runtests

@github-actions
Copy link

github-actions bot commented May 2, 2025

Build Log
Simmetrix Test Result: success
Simmetrix + CGNS Test Result: success

@Sichao25 Sichao25 marked this pull request as ready for review May 7, 2025 16:38
Copy link
Contributor

@cwsmith cwsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

@cwsmith cwsmith merged commit 8eabb61 into develop May 30, 2025
8 checks passed
@cwsmith cwsmith deleted the yus/remove_iterator_template branch May 30, 2025 18:35
@cwsmith cwsmith added v4.1.0 changes included in the 4.1.0 release C++20 labels Aug 26, 2025
@cwsmith cwsmith mentioned this pull request Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C++20 v4.1.0 changes included in the 4.1.0 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants