Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Make the CP2K orbital parser more robust for unrestricted calculations #296

Merged
merged 2 commits into from
May 9, 2022

Conversation

BvB93
Copy link
Collaborator

@BvB93 BvB93 commented May 9, 2022

Fix the CP2K MO parser being rather buggy for unrestricted calculations, especially for CP2K >= 8.2.

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #296 (b35fc8d) into master (1d254eb) will increase coverage by 1.88%.
The diff coverage is 98.97%.

@@            Coverage Diff             @@
##           master     #296      +/-   ##
==========================================
+ Coverage   82.53%   84.42%   +1.88%     
==========================================
  Files          59       60       +1     
  Lines        2497     2407      -90     
  Branches      418      411       -7     
==========================================
- Hits         2061     2032      -29     
+ Misses        335      281      -54     
+ Partials      101       94       -7     
Impacted Files Coverage Δ
src/qmflows/parsers/_cp2k_orbital_parser.py 98.70% <98.70%> (ø)
src/qmflows/common.py 95.74% <100.00%> (+0.87%) ⬆️
src/qmflows/parsers/cp2k.py 84.21% <100.00%> (+11.80%) ⬆️
src/qmflows/parsers/utils.py 82.35% <0.00%> (-3.93%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@BvB93 BvB93 merged commit 13e9f0f into master May 9, 2022
@BvB93 BvB93 deleted the unrestricted branch May 9, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant