Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Explicitly raise when the line with the number of orbitals doesn't have any actual orbitals #295

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

BvB93
Copy link
Collaborator

@BvB93 BvB93 commented Apr 26, 2022

There seems to be a CP2K bug (?) as of 8.2 where the number of occupied orbitals isn't always printed.
Explicitly raise an exception when this occurs.

Examples

 Number of electrons:                                                          2
 Number of occupied orbitals:                                                    <--- where are they!???

 TOTAL NUMBERS AND MAXIMUM NUMBERS

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #295 (4326fd3) into master (23589d8) will decrease coverage by 0.04%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
- Coverage   82.58%   82.53%   -0.05%     
==========================================
  Files          59       59              
  Lines        2492     2497       +5     
  Branches      417      418       +1     
==========================================
+ Hits         2058     2061       +3     
- Misses        334      335       +1     
- Partials      100      101       +1     
Impacted Files Coverage Δ
src/qmflows/parsers/cp2k.py 72.40% <66.66%> (-0.21%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@BvB93 BvB93 merged commit 1d254eb into master Apr 26, 2022
@BvB93 BvB93 deleted the debug branch April 26, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant