Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REV: Remove the AtomBasisKey.alias field again #285

Merged
merged 2 commits into from
Feb 4, 2022
Merged

REV: Remove the AtomBasisKey.alias field again #285

merged 2 commits into from
Feb 4, 2022

Conversation

BvB93
Copy link
Collaborator

@BvB93 BvB93 commented Feb 4, 2022

Removed again, as it makes membership checks a lot more difficult in SCM-NV/nano-qmflows#353.

@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #285 (3661d3e) into master (3f6741c) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
- Coverage   82.04%   82.00%   -0.05%     
==========================================
  Files          42       42              
  Lines        2206     2201       -5     
  Branches      369      368       -1     
==========================================
- Hits         1810     1805       -5     
  Misses        306      306              
  Partials       90       90              
Impacted Files Coverage Δ
src/qmflows/common.py 94.73% <ø> (-0.14%) ⬇️
src/qmflows/parsers/_cp2k_basis_parser.py 98.03% <100.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f6741c...3661d3e. Read the comment docs.

@BvB93 BvB93 merged commit 63030c6 into master Feb 4, 2022
@BvB93 BvB93 deleted the rev branch February 4, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant