Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix a bug in JSD score #21

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Fix: Fix a bug in JSD score #21

merged 1 commit into from
Feb 6, 2025

Conversation

tiadams
Copy link
Member

@tiadams tiadams commented Feb 6, 2025

Fix a major Bug in JSD computation:

  • Previously, missing values were only removed for real data, resulting in a single bin filled with NaN for the synthetic data if it contained missing entries
  • Synthetic data is now also checked for missing data and it is removed for the JSD calculation

@tiadams tiadams merged commit d065df1 into main Feb 6, 2025
6 checks passed
@tiadams tiadams deleted the jsd-bugfix branch February 6, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant