Fix to return the ocLazyLoading promise on resolve #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… loaded before render the view
…imation provider when loading a module with ngModule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you add your own directives in the filesConfig property, they are loaded via ocLazyLoad in the resolve property for every $state in the Styleguide App.
error: as the ocLazyLoading promise is not being returned in the resolve, you might experience some weird errors saying that your directives are not defined, also, when you reload the browser, sometimes you will experience an error with $$animateJS
the $$animateJS error is related to angular/angular.js#14291
also, I added the return statement in the resolve property to return the ocLazyLoad promise so the view will not be printed until all the modules are loaded.