Fixes #42. Scrolling from javascript not working when overflow: auto is set on body. #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does a deleting a line from a CSS file causes the build to fail ? Am I merging to the wrong branch ? |
|
@gambit3 I also had this issue with my last CSS-only PR. Try a |
arturmarc
force-pushed
the
anchor_links_fix
branch
3 times, most recently
from
20b214b to
cefeea1
Compare
…to set on body.
arturmarc
force-pushed
the
anchor_links_fix
branch
from
cefeea1 to
07ae310
Compare
|
It seems after running locally it needed a bower.json file fix. Not sure why. Build passing now. |
|
Great change! @junaidrsd Could you merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not a angular issue - all things are there to enable smooth scrolling using anchor links. It was a css thing that causes js based scrolling not to work.