Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature navigation #920

Merged
merged 10 commits into from
Apr 20, 2016
Merged

Feature navigation #920

merged 10 commits into from
Apr 20, 2016

Conversation

junaidrsd
Copy link
Contributor

Side navigation
Third navigation level
Prevent to load sections on main navigation level
Hamburger menu styles on mobile view (only with sidebar nav)

@junaidrsd junaidrsd force-pushed the feature-navigation branch from 6184006 to d0cb8ec Compare April 12, 2016 19:27
@MatthieuScarset
Copy link

MatthieuScarset commented Apr 18, 2016

Seems to include great enhancements!
Hopefully this pull make it throught the acceptation process.
Thanks @junaidrsd

@@ -80,6 +80,7 @@ gulp.task('dev:generate', () => {
return gulp.src(['lib/app/css/*.css'])
.pipe(styleguide.generate({
title: 'SC5 Styleguide',
sideNav: true,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this be the new default value, so if you update toNav changes to sideNav? If so, I would change default value to false.

@junaidrsd junaidrsd merged commit 2aaf302 into SC5:master Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants