Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach sg-insert to include components with modifiers #808

Merged
merged 1 commit into from
Oct 8, 2015
Merged

Teach sg-insert to include components with modifiers #808

merged 1 commit into from
Oct 8, 2015

Conversation

kraftner
Copy link
Contributor

see #784

@kraftner
Copy link
Contributor Author

Sorry for the mess. I'll create an new clean PR once this is ready to go in.

But first I'd need some feedback if this is working for you.
Also I'd like to add this to the test coverage but not really sure were to start.

@Grienauer
Copy link

+1

@varya
Copy link
Contributor

varya commented Oct 1, 2015

Looks good. I would also add the tests about this case in here https://github.com/SC5/sc5-styleguide/blob/master/test/unit/modules/section-references.test.js

@kraftner
Copy link
Contributor Author

kraftner commented Oct 1, 2015

So, this is the first time I've written a JS test, hopefully it is useful 😄

If this all looks good to you I can create a new, clean PR if you don't want to merge all this separate commits.

@varya
Copy link
Contributor

varya commented Oct 6, 2015

Yes, sure. I'll merge the new one.

@kraftner
Copy link
Contributor Author

kraftner commented Oct 6, 2015

Okay this finally made me get into the magic realm of rebasing and force-pushing.

I think this is now ready to be merged.

varya added a commit that referenced this pull request Oct 8, 2015
@varya varya merged commit 03185a4 into SC5:master Oct 8, 2015
@varya varya changed the title first shot at including modifiers sg-insert working with modifiers modifiers Oct 8, 2015
@varya
Copy link
Contributor

varya commented Oct 8, 2015

Thank you very much!

@kraftner
Copy link
Contributor Author

kraftner commented Oct 8, 2015

Thank you for everything else!

You can also close #784 now.

@varya varya changed the title sg-insert working with modifiers modifiers Teach sg-insert to include components with modifiers Oct 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants