gonzales-pe upgrades to 3.0.0-26 #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| 'use strict'; | |||
|
|
|||
| var gonzales = require('gonzales-pe'), | |||
| gonzo = require('gonzales-ast'), | |||
| gonzo = require('./node_traverser'), | |||
There was a problem hiding this comment.
I think it wold be nice to change the name of this variable from gonzo to traverser. So it will be more clear that we are using our own module.
There was a problem hiding this comment.
The node_traverser module is missing tests.
There was a problem hiding this comment.
You're right I'll make those changes and add the tests.
removed redundant tests removed redundant tests tests added for ast-traverser change the file name to same naming convention test added to traverser
junaidrsd
force-pushed
the
gonazale-pe/[email protected]
branch
from
9a05aaf to
19520ff
Compare
hannu
added a commit
that referenced
this pull request
Apr 27, 2015
gonzales-pe upgrades to 3.0.0-26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.