Feaure/update angular version #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the dependencies of the app have been updated to their latest stable versions. Angular has ben updated to 1.6.x. No breaking change is expected.
The .success method was deprecated in the version 1.6.x of angular, now standard .thens are recommended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the dependencies of the app, to their latest version. Within this, updates angular to 1.6.x.
In #1072 I suggested this roadmap to update the angular version:
However, after having worked in the update, I realized that the proposed workflow is not required, because there are no breaking changes that might affect users of the project.
The only change relevant is in this commit:
https://github.com/DanielaValero/sc5-styleguide/commit/3fa0c39d6d134d5fd71f415a94678459a7ef836f
Which will not affect users, as is in a function that is encapsulated in the project.
Closes #1072