-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements move
function
#17
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
'use strict'; | ||
|
||
module.exports = function (from, to, options) { | ||
this.copy(from, to, options); | ||
this.delete(from, options); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
'use strict'; | ||
|
||
var assert = require('assert'); | ||
var path = require('path'); | ||
var sinon = require('sinon'); | ||
var editor = require('..'); | ||
var memFs = require('mem-fs'); | ||
|
||
describe('#move()', function () { | ||
beforeEach(function() { | ||
var store = memFs.create(); | ||
this.fs = editor.create(store); | ||
}); | ||
|
||
it('move file', function () { | ||
var filepath = path.join(__dirname, 'fixtures/file-a.txt'); | ||
var initialContents = this.fs.read(filepath); | ||
var newpath = '/new/path/file.txt'; | ||
this.fs.move(filepath, newpath); | ||
assert.equal(this.fs.read(newpath), initialContents); | ||
assert.throws(this.fs.read.bind(this.fs, filepath)); | ||
}); | ||
|
||
it('move directory', function() { | ||
var filename = 'file.txt'; | ||
var dirpath = path.join(__dirname, 'fixtures/nested'); | ||
var filepath = path.join(dirpath, filename); | ||
var newdirpath = '/new/path'; | ||
var newfilepath = path.join(newdirpath, filename); | ||
this.fs.move(dirpath, newdirpath); | ||
assert.equal(this.fs.store.get(newfilepath).state, 'modified'); | ||
assert.throws(this.fs.read.bind(this.fs, filepath)); | ||
}); | ||
|
||
it('move file to an existing `to` path', function() { | ||
var filepath = path.join(__dirname, 'fixtures/file-a.txt'); | ||
var initialContents = this.fs.read(filepath); | ||
var newpath = path.join(__dirname, 'fixtures/nested/file.txt'); | ||
this.fs.move(filepath, newpath); | ||
assert.equal(this.fs.read(newpath), initialContents); | ||
assert.throws(this.fs.read.bind(this.fs, filepath)); | ||
}); | ||
|
||
it('move directory to an existing `to` path (as a directory)', function () { | ||
var dirpath = path.join(__dirname, 'fixtures/other'); | ||
var filepath = path.join(__dirname, 'another.txt'); | ||
var contents = 'another'; | ||
var fromdir = path.join(__dirname, 'fixtures/nested'); | ||
|
||
this.fs.write(filepath, contents); | ||
this.fs.move(fromdir, dirpath); | ||
|
||
assert.equal(this.fs.read(path.join(dirpath, 'file.txt')), 'nested\n'); | ||
assert.equal(this.fs.read(filepath), contents); | ||
assert.throws(this.fs.read.bind(this.fs, path.join(fromdir, 'file.txt'))); | ||
}); | ||
|
||
it('throws when moving directory to an existing `to` path (as a file)', function() { | ||
var filepath = path.join(__dirname, 'fixtures/file-a.txt'); | ||
var frompath = path.join(__dirname, 'fixtures/nested'); | ||
|
||
assert.throws(this.fs.move.bind(this.fs, frompath, filepath)); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SBoudrias If you disagree with this behavior, then #14 may make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seem fine, we just overwrite the
to
file correct?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but the overwrite could be unintentional, especially when it is done without giving any warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's to be handled by write filters.