Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-notification-list-group): group header hight is shorter when collapsed #9953

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kskondov
Copy link
Contributor

There was too much space between collapsed group headers

Fixes: #9911

…collapsed

There was too much space between collapsed group headers

Fixes: #9911
@kskondov kskondov requested review from LidiyaGeorgieva and a team September 27, 2024 08:06
Copy link
Contributor

@LidiyaGeorgieva LidiyaGeorgieva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the group is expanded/collapsed the group header changes its position. This is a bug

@@ -41,6 +41,10 @@
cursor: pointer;
}

.ui5-nli-group-header[aria-expanded="false"] {
Copy link
Contributor

@LidiyaGeorgieva LidiyaGeorgieva Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add new attribute (expanded/collapse for example) for the element with class "ui5-nli-group-header" and use it here. If the ACC is changed the height will no longer work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui5-notification-lit-group-item]: group header height should be shorter
2 participants