Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ui5-dialog): improve basic sample #9876

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Conversation

s-todorova
Copy link
Contributor

The basic sample now showcases achieving a confirmation dialog with two buttons like in opneui5 by using ui5-toolbar and ui5-toolbar-buttons.

BGSOFUIRODOPI-3324

The basic sample now showcases achieving a confirmation dialog with
two buttons like in opneui5 by using ui5-toolbar and ui5-toolbar-buttons

BGSOFUIRODOPI-3324
@s-todorova s-todorova requested a review from a team September 16, 2024 05:33
Copy link
Member

@TeodorTaushanov TeodorTaushanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adapt all samples to use toolbar as a footer except "Usage of Bar as header/footer"

@s-todorova s-todorova merged commit a211dd2 into main Sep 17, 2024
10 checks passed
@s-todorova s-todorova deleted the confirmation-dialog-sample branch September 17, 2024 08:27
nowakdaniel pushed a commit that referenced this pull request Sep 25, 2024
The samples now showcase achieving a confirmation dialog with two buttons like in opneui5, by using ui5-toolbar and ui5-toolbar-buttons.

BGSOFUIRODOPI-3324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants