Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-slider, ui5-range-slider): add input as a tooltip #9547

Open
wants to merge 53 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 37 commits
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
d071fe9
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Jul 23, 2024
76b9df2
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Jul 24, 2024
fc4c145
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Jul 25, 2024
f54169f
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Jul 25, 2024
8778869
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Jul 25, 2024
f1dc9c7
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Jul 26, 2024
b32dfdd
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Jul 31, 2024
5e2f4b4
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Jul 31, 2024
3f0a96d
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Aug 12, 2024
9389faf
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Aug 12, 2024
917a8d9
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Aug 12, 2024
011ccc9
Merge branch 'slider-input-tooltip' of https://github.com/SAP/ui5-web…
ndeshev Aug 12, 2024
82fca2e
Merge branch 'main' into slider-input-tooltip
ndeshev Aug 12, 2024
4355fc2
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Aug 12, 2024
1334ae7
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Aug 12, 2024
f01cb06
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Aug 14, 2024
a8e0808
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Aug 14, 2024
791c035
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Aug 16, 2024
a02e5c4
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Aug 20, 2024
c5c45a2
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Aug 20, 2024
13d14ae
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Aug 20, 2024
bc0d25b
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Aug 22, 2024
5de1e4d
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Aug 23, 2024
459d15a
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Aug 23, 2024
f7e2915
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Aug 23, 2024
ecce66e
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Aug 25, 2024
ba84adc
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Aug 25, 2024
4da66e6
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Aug 25, 2024
78b74ea
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Aug 26, 2024
ca45659
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Aug 26, 2024
bb5df87
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Aug 26, 2024
049b922
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Aug 26, 2024
37f145f
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Sep 10, 2024
715da42
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Sep 10, 2024
5735d0c
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Sep 13, 2024
3b34a23
feat(ui5-slider, ui5-range-slider): fix aria-describedby attribute fo…
ndeshev Sep 13, 2024
11e343e
feat(ui5-slider, ui5-range-slider): fix property getter typo
ndeshev Sep 13, 2024
96afa78
feat(ui5-slider, ui5-range-slider): add event firing
ndeshev Sep 14, 2024
125bf06
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Sep 15, 2024
65c7588
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Sep 15, 2024
a39435c
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Sep 16, 2024
e6793b8
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Sep 16, 2024
c471639
fix(ui5-multi-combobox): fix aria-describedby token count
Okiana Sep 17, 2024
33071a6
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Sep 18, 2024
01e69ac
Merge branch 'mcb-ariadescribed' of https://github.com/SAP/ui5-webcom…
ndeshev Sep 18, 2024
6f2875e
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Sep 25, 2024
6006209
Merge branch 'main' into slider-input-tooltip
ndeshev Sep 25, 2024
3342e70
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Sep 25, 2024
713bd57
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Sep 26, 2024
edb2c98
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Sep 26, 2024
9773346
Merge branch 'main' into slider-input-tooltip
ndeshev Sep 26, 2024
b1f8d3a
feat(ui5-slider, ui5-range-slider): add input as a tooltip
ndeshev Oct 1, 2024
5743e7d
Merge branch 'main' into slider-input-tooltip
ndeshev Oct 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 63 additions & 35 deletions packages/main/src/RangeSlider.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -29,49 +29,77 @@
{{/inline}}

{{#*inline "handles"}}
<div class="ui5-slider-handle ui5-slider-handle--start"
part="handle"
style="{{styles.startHandle}}"
@focusin="{{_onfocusin}}"
@focusout="{{_onfocusout}}"
role="slider"
tabindex="{{_tabIndex}}"
aria-orientation="horizontal"
aria-valuemin="{{min}}"
aria-valuemax="{{max}}"
aria-valuenow="{{startValue}}"
aria-labelledby="{{_ariaLabelledByStartHandleRefs}}"
aria-disabled="{{_ariaDisabled}}"
>
<ui5-icon name="direction-arrows" mode="Decorative" slider-icon></ui5-icon>
<div class="ui5-slider-handle-container" style="{{styles.startHandle}}" part="handle-container">

<div class="ui5-slider-handle ui5-slider-handle--start"
part="handle"
@focusin="{{_onfocusin}}"
@focusout="{{_onfocusout}}"
role="slider"
tabindex="{{_tabIndex}}"
aria-orientation="horizontal"
aria-valuemin="{{min}}"
aria-valuemax="{{max}}"
aria-valuenow="{{startValue}}"
aria-labelledby="{{_ariaLabelledByStartHandleRefs}}"
aria-disabled="{{_ariaDisabled}}"
aria-describedby="{{_ariaDescribedByHandleText}}"
ndeshev marked this conversation as resolved.
Show resolved Hide resolved
>
<ui5-icon name="direction-arrows" slider-icon></ui5-icon>
ndeshev marked this conversation as resolved.
Show resolved Hide resolved
</div>

{{#if showTooltip}}
<div class="ui5-slider-tooltip ui5-slider-tooltip--start" style="{{styles.tooltip}}">
<div class="ui5-slider-tooltip ui5-slider-tooltip--start" style="{{styles.tooltip}}">
{{#if editableTooltip}}
<ui5-input
type="Number"
value="{{startValue}}"
accessible-name-ref="ui5-slider-accName ui5-slider-InputLabel"
@focusout="{{_onInputFocusOut}}"
@keydown="{{_onInputKeydown}}"
data-sap-ui-start-value
tabindex="-1"
></ui5-input>
{{else}}
<span class="ui5-slider-tooltip-value">{{tooltipStartValue}}</span>
</div>
{{/if}}
</div>
{{/if}}
</div>

<div class="ui5-slider-handle ui5-slider-handle--end"
part="handle"
style="{{styles.endHandle}}"
@focusin="{{_onfocusin}}"
@focusout="{{_onfocusout}}"
role="slider"
tabindex="{{_tabIndex}}"
aria-orientation="horizontal"
aria-valuemin="{{min}}"
aria-valuemax="{{max}}"
aria-valuenow="{{endValue}}"
aria-labelledby="{{_ariaLabelledByEndHandleRefs}}"
aria-disabled="{{_ariaDisabled}}"
>
<ui5-icon name="direction-arrows" mode="Decorative" slider-icon></ui5-icon>
<div class="ui5-slider-handle-container" style="{{styles.endHandle}}" part="handle-container">
<div class="ui5-slider-handle ui5-slider-handle--end"
part="handle"
@focusin="{{_onfocusin}}"
@focusout="{{_onfocusout}}"
role="slider"
tabindex="{{_tabIndex}}"
aria-orientation="horizontal"
aria-valuemin="{{min}}"
aria-valuemax="{{max}}"
aria-valuenow="{{endValue}}"
aria-labelledby="{{_ariaLabelledByEndHandleRefs}}"
aria-describedby="{{_ariaDescribedByHandleText}}"
aria-disabled="{{_ariaDisabled}}"
>
<ui5-icon name="direction-arrows" slider-icon></ui5-icon>
</div>

{{#if showTooltip}}
<div class="ui5-slider-tooltip ui5-slider-tooltip--end" style="{{styles.tooltip}}">
<div class="ui5-slider-tooltip ui5-slider-tooltip--end" style="{{styles.tooltip}}">
{{#if editableTooltip}}
<ui5-input
type="Number"
value="{{endValue}}"
accessible-name-ref="ui5-slider-accName ui5-slider-InputLabel"
@focusout="{{_onInputFocusOut}}"
@keydown="{{_onInputKeydown}}"
data-sap-ui-end-value
tabindex="-1"
></ui5-input>
{{else}}
<span class="ui5-slider-tooltip-value">{{tooltipEndValue}}</span>
</div>
{{/if}}
</div>
{{/if}}
</div>
{{/inline}}
Loading