-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ui5-list): update focus handling #9073
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetyaMarkovaBogdanova
approved these changes
May 29, 2024
TeodorTaushanov
approved these changes
May 29, 2024
@kgogov Thank you for your contributing to the test files of our team but In the future, could you please add at least one member from our team as a reviewer when making any changes to the components we own, also I see that there were some indentation changes. Our team prefers to avoid reformatting code unless absolutely necessary to preserve the git history and avoid potential merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted the focus display rules for
ui5-list
and other derivative list items. On desktop, the focus outline is always visible. On mobile devices, the focus outline appears only when using an external keyboard and remains hidden for touch focus.Related issues: #8320, #7858