Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui5-list): update focus handling #9073

Merged
merged 8 commits into from
May 29, 2024
Merged

chore(ui5-list): update focus handling #9073

merged 8 commits into from
May 29, 2024

Conversation

kgogov
Copy link
Member

@kgogov kgogov commented May 28, 2024

Adjusted the focus display rules for ui5-list and other derivative list items. On desktop, the focus outline is always visible. On mobile devices, the focus outline appears only when using an external keyboard and remains hidden for touch focus.

Related issues: #8320, #7858

Adjusted ui5-list and other derivatives list items focus display rules.
On desktop, focus outline is always visible. For mobile, focus outline
only appears with an external keyboard, it remains hidden for touch
focus.

Related to: #8320, #7858
@kgogov kgogov merged commit 8b19ea9 into main May 29, 2024
10 checks passed
@kgogov kgogov deleted the list-focus-update branch May 29, 2024 14:28
@ivoplashkov
Copy link
Member

ivoplashkov commented May 29, 2024

@kgogov Thank you for your contributing to the test files of our team but In the future, could you please add at least one member from our team as a reviewer when making any changes to the components we own, also I see that there were some indentation changes. Our team prefers to avoid reformatting code unless absolutely necessary to preserve the git history and avoid potential merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants