Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-button): new focus handling #8253

Closed
wants to merge 6 commits into from
Closed

feat(ui5-button): new focus handling #8253

wants to merge 6 commits into from

Conversation

pskelin
Copy link
Contributor

@pskelin pskelin commented Feb 7, 2024

Example implementation for new focus handling described in #8250

@ilhan007
Copy link
Member

ilhan007 commented Feb 28, 2024

Note: https://github.com/SAP/ui5-webcomponents/blob/main/packages/main/src/SplitButton.ts#L281
Split Button uses the focused property and this will stop working.

We recommend reworking the SplitButton not to rely on btn.focused as focused is removed:

Screenshot 2024-02-28 at 16 16 11

@ilhan007
Copy link
Member

FYI @DMihaylova

@github-actions github-actions bot added the Stale label Mar 21, 2024
@github-actions github-actions bot closed this Mar 29, 2024
@nnaydenow nnaydenow deleted the focus-handling branch May 29, 2024 10:25
@nnaydenow nnaydenow restored the focus-handling branch May 29, 2024 10:25
@nnaydenow nnaydenow deleted the focus-handling branch August 2, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants