Skip to content

[FEATURE] Bundling: Remove option 'usePredefineCalls' #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[FEATURE] Bundling: Remove option 'usePredefineCalls' #725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions lib/validation/schema/specVersion/kind/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,10 +397,6 @@
"type": "boolean",
"default": false
},
"usePredefineCalls": {
Copy link
Member

@matz3 matz3 May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes existing specVersions, which is not intended

"type": "boolean",
"default": false
},
"numberOfParts": {
"type": "number",
"default": 1
Expand All @@ -423,10 +419,6 @@
"type": "boolean",
"default": false
},
"usePredefineCalls": {
"type": "boolean",
"default": false
},
"numberOfParts": {
"type": "number",
"default": 1
Expand Down
11 changes: 0 additions & 11 deletions test/lib/validation/schema/__helper__/builder-bundleOptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ export default {
"optimize": false,
"decorateBootstrapModule": false,
"addTryCatchRestartWrapper": true,
"usePredefineCalls": true,
"numberOfParts": 8,
"sourceMap": false
}
Expand Down Expand Up @@ -82,7 +81,6 @@ export default {
"optimize": "invalid value",
"decorateBootstrapModule": {"invalid": "value"},
"addTryCatchRestartWrapper": ["invalid value"],
"usePredefineCalls": 12,
"numberOfParts": true,
"sourceMap": 55
}
Expand Down Expand Up @@ -115,15 +113,6 @@ export default {
},
message: "should be boolean"
},
{
keyword: "type",
dataPath:
"/builder/bundles/0/bundleOptions/usePredefineCalls",
params: {
type: "boolean",
},
message: "should be boolean"
},
{
keyword: "type",
dataPath:
Expand Down
3 changes: 1 addition & 2 deletions test/lib/validation/schema/specVersion/kind/project/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,7 @@ SpecificationVersion.getVersionsForRange(">=2.0").forEach(function(specVersion)
"bundleOptions": {
"optimize": true,
"decorateBootstrapModule": true,
"addTryCatchRestartWrapper": true,
"usePredefineCalls": true
"addTryCatchRestartWrapper": true
}
},
{
Expand Down
3 changes: 1 addition & 2 deletions test/lib/validation/schema/specVersion/kind/project/library.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,7 @@ SpecificationVersion.getVersionsForRange(">=2.0").forEach(function(specVersion)
"bundleOptions": {
"optimize": true,
"decorateBootstrapModule": true,
"addTryCatchRestartWrapper": true,
"usePredefineCalls": true
"addTryCatchRestartWrapper": true
}
},
{
Expand Down