Skip to content

Conversation

@RandomByte
Copy link
Member

@RandomByte RandomByte commented Oct 28, 2025

For internal PoC usage.

This change is not active in regular builds. To activate it, the environment variable UI5_CLI_EXPERIMENTAL_BUNDLE_INFO_PRELOAD needs to be set to any value.

JIRA: CPOUI5FOUNDATION-1165

@RandomByte
Copy link
Member Author

To be clarified: Should this be released as a pre-release of UI5 Builder and UI5 CLI (requires dedicated release pipeline) or as regular patches (with an empty changelog)? I would prefer the first option.

@coveralls
Copy link

coveralls commented Oct 28, 2025

Coverage Status

coverage: 94.429% (-0.6%) from 95.0%
when pulling 44d2548 on bundle-info-preload
into 68908e0 on v4.

@RandomByte
Copy link
Member Author

To be clarified: Should this be released as a pre-release of UI5 Builder and UI5 CLI (requires dedicated release pipeline) or as regular patches (with an empty changelog)? I would prefer the first option.

As discussed with @matz3, we tend to release this as a regular patch and consume it in the regular way.

@RandomByte RandomByte marked this pull request as ready for review October 29, 2025 13:39
matz3
matz3 previously approved these changes Oct 30, 2025
@codeworrior
Copy link
Member

Somehow review comments that I had made, went lost. Please wait with a merge, I'll redo the comments.

@RandomByte
Copy link
Member Author

Somehow review comments that I had made, went lost. Please wait with a merge, I'll redo the comments.

Oh no! I force pushed, but PR comments should have been preserved. Did you maybe comment directly on the commit?

@codeworrior
Copy link
Member

Not sure, maybe. Indeed, while I was reviewing, you force pushed in parallel.

Copy link
Member

@codeworrior codeworrior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RandomByte RandomByte merged commit 2461b2c into v4 Oct 30, 2025
20 checks passed
@RandomByte RandomByte deleted the bundle-info-preload branch October 30, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants