[SAPBTPCFS-3288] CUSTOM TEMPLATES FOR SECRETS #408

I065450 · 2024-03-14T12:08:53Z

No description provided.

UA changes

README.md

avilupu · 2024-03-18T14:32:28Z

README.md

@@ -286,31 +286,34 @@ SAP BTP service operator search for the credentials in the following order:

 #### Service Binding

-1.  To get access credentials to your service instance and make it available in the cluster so that your applications can use it, create a `ServiceBinding` custom resource, and set the `serviceInstanceName` field to the name of the `ServiceInstance` resource you created.
+To allow applications to access a service instance in your cluster, create a `ServiceBinding` custom resource. Set the `serviceInstanceName` field within the `ServiceBinding` to match the name of the `ServiceInstance` resource you previously created.


not access the service instance, but access/consume/communicate with the service (not instance).

the terminology of the previous version was better. it is actually 'get access credentials' to consume the service.

actually mentioning the term 'credentials' here is very important, as all the service binding chapter deals with credentials.

But is it a service in the cluster? Or an instance?
The rest was changed.

avilupu · 2024-03-18T14:39:20Z

README.md


-   The credentials are stored in a secret created in your cluster.
+This `ServiceBinding` is then exposed to users through a generated output: a `Secret` resource that contains securely-stored access credentials needed to connect to the `ServiceInstance`. 


the service binding is not exposed to users, but the credentials are exposed.

e.g., These access credentials are then available to consuming applications through a secret resource which is generated in your cluster.....

@avilupu this was the official Kubernetes terminology. But I'll change.

README.md

avilupu · 2024-03-18T15:02:44Z

README.md

+  name: sample-binding
+spec:
+  serviceInstanceName: sample-instance
+  secretRootKey: your-secretRootKey-value


use 'myBindingData'

Wouldn't this be myCredentialsAndInstanceData if already?? @avilupu

README.md

avilupu · 2024-03-18T15:39:07Z

README.md

+spec:
+  serviceInstanceName: sample-instance
+  secretTemplate: your-Go-template
+```


what is "your-Go-template"?

@avilupu the applied Go template?
The used Go template?

avilupu · 2024-03-18T15:39:44Z

README.md

+      password: {{ .credentials.client_secret }}
+```
+The sample-binding map on which your-Go-template operates is in the JSON format:
+


not sure I understand...

@avilupu I think we are still missing info here. Go template is applied to a data structure to generate an output. In this case, the generated output is the Secret format that we want. However, there is also a map. We need to explain more where this map comes from. @I065450

README.md

danielforsap

3 issues still open.

danielforsap · 2024-03-18T15:50:30Z

README.md

@@ -286,31 +286,34 @@ SAP BTP service operator search for the credentials in the following order:

 #### Service Binding

-1.  To get access credentials to your service instance and make it available in the cluster so that your applications can use it, create a `ServiceBinding` custom resource, and set the `serviceInstanceName` field to the name of the `ServiceInstance` resource you created.
+To allow applications to access a service instance in your cluster, create a `ServiceBinding` custom resource. Set the `serviceInstanceName` field within the `ServiceBinding` to match the name of the `ServiceInstance` resource you previously created.


But is it a service in the cluster? Or an instance?
The rest was changed.

danielforsap · 2024-03-18T15:54:47Z

README.md


-   The credentials are stored in a secret created in your cluster.
+This `ServiceBinding` is then exposed to users through a generated output: a `Secret` resource that contains securely-stored access credentials needed to connect to the `ServiceInstance`. 


@avilupu this was the official Kubernetes terminology. But I'll change.

README.md

After Avi's review 1

Changes already implemented

I065450 and others added 7 commits March 14, 2024 14:07

[SAPBTPCFS-3288] update readme

bf02f09

[SAPBTPCFS-3288] update readme

b02ecda

Update README.md

36be3cd

Update README.md

778689d

UA changes

Update README.md

385b82e

Update README.md

eea0d22

Update README.md

e77d56f

danielforsap requested a review from avilupu March 18, 2024 14:15

Update README.md

6ab11eb

avilupu previously requested changes Mar 18, 2024

View reviewed changes

danielforsap requested changes Mar 18, 2024

View reviewed changes

danielforsap added 8 commits March 18, 2024 18:15

Update README.md

8c0eebe

After Avi's review 1

Update README.md

f0f204a

Update README.md

2c9fba6

Update README.md

8caf45b

Update README.md

e9b8ca3

Update README.md

f850b01

Update README.md

307e196

Update README.md

dae922c

danielforsap approved these changes Mar 19, 2024

View reviewed changes

Update README.md

908c592

danielforsap changed the title ~~[SAPBTPCFS-3288] update readme~~ [SAPBTPCFS-3288] CUSTOM TEMPLATES FOR SECRETS Mar 26, 2024

danielforsap added 2 commits March 26, 2024 19:35

Update README.md

c1a5d3b

Update README.md

cf118f0

danielforsap merged commit b823ff8 into main Mar 27, 2024
6 checks passed

danielforsap deleted the secret_template_readme branch March 27, 2024 17:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SAPBTPCFS-3288] CUSTOM TEMPLATES FOR SECRETS #408

[SAPBTPCFS-3288] CUSTOM TEMPLATES FOR SECRETS #408

I065450 commented Mar 14, 2024

avilupu Mar 18, 2024

danielforsap Mar 18, 2024

avilupu Mar 18, 2024

danielforsap Mar 18, 2024

avilupu Mar 18, 2024

danielforsap Mar 18, 2024

avilupu Mar 18, 2024

danielforsap Mar 18, 2024

avilupu Mar 18, 2024

danielforsap Mar 18, 2024

danielforsap left a comment

danielforsap Mar 18, 2024

danielforsap Mar 18, 2024


		The credentials are stored in a secret created in your cluster.
		This `ServiceBinding` is then exposed to users through a generated output: a `Secret` resource that contains securely-stored access credentials needed to connect to the `ServiceInstance`.

[SAPBTPCFS-3288] CUSTOM TEMPLATES FOR SECRETS #408

[SAPBTPCFS-3288] CUSTOM TEMPLATES FOR SECRETS #408

Conversation

I065450 commented Mar 14, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danielforsap left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment