Skip to content

Commit

Permalink
Fix readme (#436)
Browse files Browse the repository at this point in the history
  • Loading branch information
kerenlahav authored May 20, 2024
1 parent a7fb906 commit c2aeb6f
Showing 1 changed file with 15 additions and 18 deletions.
33 changes: 15 additions & 18 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ metadata:
name: sap-btp-service-operator
namespace: sap-btp-operator
type: Opaque
stringdata:
stringData:
clientid: <clientid>
tls.crt: <certificate>
tls.key: <key>
Expand Down Expand Up @@ -228,7 +228,7 @@ metadata:
name: <namespace-name>-sap-btp-service-operator
namespace: <centrally-managed-namespace>
type: Opaque
stringdata:
stringData:
clientid: <clientid>
tls.crt: <certificate>
tls.key: <key>
Expand Down Expand Up @@ -271,7 +271,7 @@ metadata:
name: <my-secret>
namespace: <centrally managed namespace>
type: Opaque
stringdata:
stringData:
clientid: <clientid>
tls.crt: <certificate>
tls.key: <key>
Expand All @@ -280,6 +280,7 @@ stringdata:
tokenurlsuffix: "/oauth/token"
```
#### Configure the secret name in the `ServiceInstance` resource within the property `btpAccessCredentialsSecret`:
The secret must be located in the same namespace as the instance
```yaml
apiVersion: services.cloud.sap.com/v1
kind: ServiceInstance
Expand Down Expand Up @@ -458,11 +459,9 @@ metadata:
name: sample-binding
stringData:
myCredentials:
{
uri: https://my-service.authentication.eu10.hana.ondemand.com,
client_id: admin,
client_secret: ********
}
instance_guid: your-sample-instance-guid // The service instance ID
instance_name: sample-binding // Taken from the service instance external_name field if set. Otherwise from metadata.name
plan: sample-plan // The service plan name
Expand Down Expand Up @@ -495,15 +494,13 @@ metadata:
name: sample-binding
stringData:
myCredentialsAndInstance:
{
uri: https://my-service.authentication.eu10.hana.ondemand.com,
client_id: admin,
client_secret: ********,
instance_guid: your-sample-instance-guid, // The service instance id
instance_name: sample-instance-name, // Taken from the service instance external_name field if set. Otherwise from metadata.name
plan: sample-instance-plan, // The service plan name
type: sample-instance-offering, // The service offering name
}
```
##### Custom Formats

Expand Down Expand Up @@ -612,11 +609,9 @@ metadata:
instance: sample-instance
stringData:
myCredentials:
{
uri: https://my-service.authentication.eu10.hana.ondemand.com,
client_id: admin,
client_secret: ********
}
instance_guid: your-sample-instance-guid // The service instance ID
instance_name: sample-binding // Taken from the service instance external_name field if set. Otherwise from metadata.name
plan: sample-plan // The service plan name
Expand Down Expand Up @@ -725,16 +720,18 @@ spec:

The format of the `spec` in JSON
```json
"spec": {
"parameters": {
"name": "value"
},
"parametersFrom": {
"secretKeyRef": {
"name": "my-secret",
"key": "secret-parameter"
{
"spec": {
"parameters": {
"name": "value"
},
"parametersFrom": {
"secretKeyRef": {
"name": "my-secret",
"key": "secret-parameter"
}
}
}
}
}
```
The `secret` with the `secret-parameter`- named key:
Expand Down

0 comments on commit c2aeb6f

Please sign in to comment.