-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sap.m.ScrollContainer & .Page: missing focus indicator for scroll content #2785
Comments
Another case:
Now the user needs to guess where the focus went. |
Never mind. Just realized that I had a flag[1] enabled in Chrome which caused this issue. Sorry! [1] The flag was |
Ok, the issue is actually reproducible in clean-installed stable Firefox (72.0, Windows). FF behaves like Chromium-based browsers with |
Hi boghyon, The Page from the sample is a container that does not receive the focus. Like many other containers, it is just a div in the DOM, not focusable by default. Same as the page here, many posts, but the body does not receive the focus, or have an indicator. It reacts to the arrow down events, because they bubble through all non-scrollable children. So we could say that it does not need the focus to be interactive. E.g. The focus is on the 'Comment' button when I hold arrow up and the page scrolls. A sap.m.ScrollContainer, on the other hand, is a container designed to receive the focus on demand. Its API includes a property 'focusable'. Regards, |
Hi Alex, thanks for the response. It's true that divs shouldn't be focusable technically. But what's weird is that Firefox requires an additional Tab press to reach the [Toggle floating footer] button whereas other browsers don't. This leads to the issue mentioned in #2785 (comment) where FF users lose the track of focus indicator when tabbing through, since the scroll area itself gets the focus beforehand without any indicator. In other browsers, it's always clear where the focus indicator is. I guess this is a FF issue. Not sure if UI5 should do anything about it. |
There is some more info. I think we need to workaround this table, to make the experience the same in all browsers: https://allyjs.io/data-tables/focusable.html Our element is an overflowing |
Hello @boghyon , We've created an internal incident 2080023882 to investigate this problem. The status of the issue will be updated here in GitHub. Regards, |
Researched a bit more ...
Not sure the table is reliable since it's is no longer maintained and Chromium's behavior might change... |
In Firefox the visible focus outline is no longer lost on the page content with scroll when using the TAB key to navigate between elements Change-Id: Ife7fe6c147e81a6aa5ad4b33269f308bd136b91f BCP: 2080023882
Hello @boghyon , Seems like the issue is fixed by the linked above change. Therefore I am closing the issue. Best regards, |
URL (minimal example if possible)
E.g.: https://openui5nightly.hana.ondemand.com/entity/sap.m.Page/sample/sap.m.sample.PageFloatingFooter
Steps to reproduce the problem
What is the expected result?
Since the scroll content is an interactive element (scrollable with arrows, Home, End, etc.), the focus indicator should be visible there too, according to WCAG 2.1 Focus Visible SC 2.4.7 (Level AA):
What happens instead?
Any other information? (attach screenshot if possible)
In Chrome, for example, we see a blue outline:
A similar issue can be observed with
sap.m.ScrollContainer
.The text was updated successfully, but these errors were encountered: