clarify the difference between attributes and properties #3856
+261
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smahati
requested review from
hardl,
JohannesDoberer,
ndricimrr,
VincentUllal,
walmazacn and
amilewskaa
as code owners
|
not sure if this is supposed to be in the source code somewhere. |
|
Added snippets for the compound container, if this looks ok I can add snippets to the other API reference as well. |
| ```js | ||
| myContainer.deferInit = true | ||
| ``` | ||
| TODO: is it preferred to assign true or declare it to indicate it's set |
There was a problem hiding this comment.
totally fine to set it to true
| ``` | ||
|
|
||
| ```HTML | ||
| <luigi-container viewUrl="/index.html" compoundConfig='{foo: bar}'></luigi-container> |
There was a problem hiding this comment.
Not sure if we should provide an example for compould attribute in html
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
| ``` | ||
|
|
||
| ```HTML | ||
| <luigi-container viewUrl="/index.html"></luigi-container> |
There was a problem hiding this comment.
Suggested change
| <luigi-container viewUrl="/index.html"></luigi-container> | |
| <luigi-container viewurl="/index.html"></luigi-container> |
| @@ -38,6 +46,83 @@ Type: [Object](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Globa | |||
| **Meta** | |||
|
|
|||
| * **since**: 1.0.0 | |||
| TODO: better example | |||
| ```js | |||
| myContainer.compoundConfig = lcc.compoundConfig = { | |||
There was a problem hiding this comment.
Suggested change
| myContainer.compoundConfig = lcc.compoundConfig = { | |
| myContainer.compoundConfig = { |
| ``` | ||
|
|
||
| ```HTML | ||
| <luigi-container viewUrl="/index.html" compoundConfig='{foo: bar}'></luigi-container> |
There was a problem hiding this comment.
Suggested change
| <luigi-container viewUrl="/index.html" compoundConfig='{foo: bar}'></luigi-container> | |
| <luigi-container viewUrl="/index.html" compound-config='{foo: bar}'></luigi-container> |
| ``` | ||
| TODO: is it preferred to assign true or declare it to indicate it's set | ||
| ```HTML | ||
| <luigi-container viewUrl="/index.html" deferInit="true"></luigi-container> |
There was a problem hiding this comment.
Suggested change
| <luigi-container viewUrl="/index.html" deferInit="true"></luigi-container> | |
| <luigi-container viewUrl="/index.html" defer-init="true"></luigi-container> |
| ``` | ||
|
|
||
| ```HTML | ||
| <luigi-container viewUrl="/index.html" nodeParams='{"node":"param"}'></luigi-container> |
There was a problem hiding this comment.
Suggested change
| <luigi-container viewUrl="/index.html" nodeParams='{"node":"param"}'></luigi-container> | |
| <luigi-container viewUrl="/index.html" node-params='{"node":"param"}'></luigi-container> |
| ``` | ||
|
|
||
| ```HTML | ||
| <luigi-container viewUrl="/index.html" noShadow='true'></luigi-container> |
There was a problem hiding this comment.
Suggested change
| <luigi-container viewUrl="/index.html" noShadow='true'></luigi-container> | |
| <luigi-container viewUrl="/index.html" no-shadow='true'></luigi-container> |
| ``` | ||
|
|
||
| ```HTML | ||
| <luigi-container viewUrl="/index.html" userSettings='{"language": "de", "theme":"sap_horizon"}'></luigi-container> |
There was a problem hiding this comment.
Suggested change
| <luigi-container viewUrl="/index.html" userSettings='{"language": "de", "theme":"sap_horizon"}'></luigi-container> | |
| <luigi-container viewUrl="/index.html" user-settings='{"language": "de", "theme":"sap_horizon"}'></luigi-container> |
| ``` | ||
|
|
||
| ```HTML | ||
| <luigi-container viewUrl="/index.html" documentTitle='Luigi App'></luigi-container> |
There was a problem hiding this comment.
Suggested change
| <luigi-container viewUrl="/index.html" documentTitle='Luigi App'></luigi-container> | |
| <luigi-container viewUrl="/index.html" document-title='Luigi App'></luigi-container> |
| ``` | ||
|
|
||
| ```HTML | ||
| <luigi-container viewUrl="/index.html" hasBack='/detailsPage'></luigi-container> |
There was a problem hiding this comment.
Suggested change
| <luigi-container viewUrl="/index.html" hasBack='/detailsPage'></luigi-container> | |
| <luigi-container viewUrl="/index.html" has-back='/detailsPage'></luigi-container> |
| ``` | ||
|
|
||
| ```HTML | ||
| <luigi-container viewUrl="/index.html" dirtyStatus='true'></luigi-container> |
There was a problem hiding this comment.
Suggested change
| <luigi-container viewUrl="/index.html" dirtyStatus='true'></luigi-container> | |
| <luigi-container viewUrl="/index.html" dirty-status='true'></luigi-container> |
| ``` | ||
|
|
||
| ```HTML | ||
| <luigi-container viewUrl="/index.html" activeFeatureToggleList='["enable-foo", "allow-bar"]'></luigi-container> |
There was a problem hiding this comment.
Suggested change
| <luigi-container viewUrl="/index.html" activeFeatureToggleList='["enable-foo", "allow-bar"]'></luigi-container> | |
| <luigi-container viewUrl="/index.html" active-feature-toggle-list='["enable-foo", "allow-bar"]'></luigi-container> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Fixed #3848