Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the difference between attribute and property in Container Docu #3848

Open
ndricimrr opened this issue Aug 7, 2024 · 0 comments · May be fixed by #3856
Open

Clarify the difference between attribute and property in Container Docu #3848

ndricimrr opened this issue Aug 7, 2024 · 0 comments · May be fixed by #3856
Assignees
Labels
documentation documentation tasks

Comments

@ndricimrr
Copy link
Contributor

ndricimrr commented Aug 7, 2024

<luigi-container viewUrl="/index.html" sandbox-rules='["allow-scripts", "allow-same-origin"]'></luigi-container>
or
myContainer.sandboxRules = ["allow-scripts", "allow-same-origin"]

Are both correct uses.

Discuss of a way to show on the documentation of Container API / Compound Container API that properties and attributes are usually distinguished with a dash.

This seems to be a standard here

Discuss where to put the notice, or if it makes even sense to put any notice.

Whether we put it at the top, of the API page for Container and Compound Container, or for each property separately.

Maybe just a notice
This document outlines the properties provided by the Luigi Container. --- include here a very short statement that mentions the standard for the dash ---

@ndricimrr ndricimrr added the documentation documentation tasks label Aug 7, 2024
@smahati smahati linked a pull request Aug 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants