Fix check for missing key or value properties

SAP · Sep 5, 2019 · 23b0374 · 23b0374
1 parent ada66e3
commit 23b0374
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/framework.js b/lib/framework.js
@@ -166,7 +166,7 @@ class Framework {
 					this.logger.log("error", ErrorMessage.urlParameterNotObject(urlParameter));
 					throw new Error(ErrorMessage.failure());
 				}
-				if (!urlParameter.key || !urlParameter.value) {
+				if (urlParameter.key === undefined || urlParameter.value === undefined) {
 					this.logger.log("error", ErrorMessage.urlParameterMissingKeyOrValue(urlParameter));
 					throw new Error(ErrorMessage.failure());
 				}

diff --git a/test/framework.test.js b/test/framework.test.js
@@ -456,6 +456,10 @@ describe("urlParameters", () => {
 					{
 						key: "test",
 						value: "🦆"
+					},
+					{
+						key: 0,
+						value: "🐴"
 					}
 				]
 			}
@@ -470,6 +474,9 @@ describe("urlParameters", () => {
 		expect(config.client.ui5.urlParameters).toStrictEqual([{
 			key: "test",
 			value: "🦆"
+		}, {
+			key: 0,
+			value: "🐴"
 		}]);
 	});
 });