Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kanikoExecute): preparation for multi-arch builds #3515

Merged
merged 7 commits into from
Feb 9, 2022

Conversation

v0lkc
Copy link
Member

@v0lkc v0lkc commented Feb 8, 2022

Changes

Working on adding support for building multi-arch docker images. A key requirement is the binfmt_misc support by the host and with this PR a warning message gets printed whenever this is not the case. This is related to #3510

  • Tests
  • Documentation

@v0lkc v0lkc requested a review from OliverNocon February 8, 2022 10:44
Copy link
Member

@OliverNocon OliverNocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just not sure about the binfmt check since it will always run in kaniko container. No other container is currently supported by Kaniko AFAIK

cmd/kanikoExecute.go Show resolved Hide resolved
@OliverNocon
Copy link
Member

/it

@pre
Copy link

pre commented Jul 30, 2024

@OliverNocon @v0lkc what is still missing to support multiarchitecture builds?

It doesn't work yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants