[WIP]docs(styles): font awesome example [ci visual] #4724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fundamental-styles ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
IB002
changed the title
droshev
force-pushed
the
docs/font-awesome
branch
from
accaabe
to
0c14642
Compare
droshev
force-pushed
the
docs/font-awesome
branch
from
0c14642
to
e907eaf
Compare
N1XUS
reviewed
Jul 28, 2023
There was a problem hiding this comment.
@IB002 Nice job. One thing to consider: we often use class*=sap-icon selector to style inner icons. As you may see, it aims only at sap-icon font family and will not have any effect on any other third-party icons. @InnaAtanasova any thoughts?
g-cheishvili
approved these changes
Jul 31, 2023
droshev
changed the title
|
/rebase |
|
closing it for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Relates to #3179
Description
Added examples for Font Awesome
Screenshots
N/A