Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): cache user selection after searching for new user list for approval flow #12505

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

fix(platform): cache user selection and fix cancel functionality

8efde6d
Select commit
Loading
Failed to load commit list.
Open

fix(platform): cache user selection after searching for new user list for approval flow #12505

fix(platform): cache user selection and fix cancel functionality
8efde6d
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable failed Oct 7, 2024 in 8s

1/3 Fail(s): APPROVALS

Status: FAIL

    Here are some stats of the run:
    3 validations were ran.
    2 PASSED
    1 FAILED

Details

✔️ Validator: TITLE

  • ✔️ title must exclude '^[WIP]'
    Input : fix(platform): cache user selection after searching for new user list for approval flow
    Settings : {"must_exclude":{"regex":"^\\[WIP\\]","message":"This is work in progress. Do not merge yet."}}
  • ✔️ title must include '^(feat|docs|chore|fix|test)((\w+))?(:|().+$'
    Input : fix(platform): cache user selection after searching for new user list for approval flow
    Settings : {"must_include":{"regex":"^(feat|docs|chore|fix|test)(\\(\\w+\\))?(:|\\().+$","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '[ ]'
    Input : closes #12093
    ng-15 #12107
    Settings : {"must_exclude":{"regex":"\\[ \\]","message":"There are incomplete TODO task(s) unchecked."}}

❌ Validator: APPROVALS

  • (approvals: InnaAtanasova required OR approvals: droshev required OR approvals: dpavlenishvili required OR approvals: mikerodonnell89 required OR approvals count is less than "2")
    Input :
    Settings : {"or":[{"required":{"reviewers":["InnaAtanasova"]}},{"required":{"reviewers":["droshev"]}},{"required":{"reviewers":["dpavlenishvili"]}},{"required":{"reviewers":["mikerodonnell89"]}},{"min":{"count":2}}]}